Cross-site scripting vulnerability in TinyMCE
Published 28 May 2021 · Updated 27 May 2021
Affected package
- Affected
- <5.7.1
- Fixed in
- 5.7.1
npm install tinymce@5.7.1Details
Impact
A cross-site scripting (XSS) vulnerability was discovered in the URL sanitization logic of the core parser for form elements. The vulnerability allowed arbitrary JavaScript execution when inserting a specially crafted piece of content into the editor using the clipboard or APIs, and then submitting the form. However, as TinyMCE does not allow forms to be submitted while editing, the vulnerability could only be triggered when the content was previewed or rendered outside of the editor. This impacts all users who are using TinyMCE 5.7.0 or lower.
Patches
This vulnerability has been patched in TinyMCE 5.7.1 by improved URL sanitization logic.
Workarounds
To work around this vulnerability, either:
- Upgrade to TinyMCE 5.7.1 or higher
- Manually sanitize
formURL attributes using a TinyMCE node filter. - Disable
formelements in your content using the invalid_elements setting.
Example: Sanitizing using a node filter
editor.parser.addNodeFilter('form', function(nodes) {
nodes.forEach(function(node) {
if (node.attributes) {
node.attributes.forEach(function(attr) {
var name = attr.name;
var value = attr.value;
// Sanitize the attribute value here or remove it entirely
var sanitizedValue = ...;
node.attr(name, santizedValue);
});
}
});
});Example: Using invalid_elements
invalid_elements: 'form'
Acknowledgements
Tiny Technologies would like to thank Mikhail Khramenkov at Solar Security Research Team for discovering this vulnerability.
References
https://www.tiny.cloud/docs/release-notes/release-notes571/#securityfixes
For more information
If you have any questions or comments about this advisory:
- Open an issue in the TinyMCE repo
- Email us at [infosec@tiny.cloud](mailto:infosec@tiny.cloud)
Is GHSA-5vm8-hhgr-jcjp in any of your client repos?
Checking one package by hand is fine. Checking it across forty client projects is not. NPMscan reads the lockfiles in every GitHub repo you pick, finds each project with an affected tinymce, and gives you the command that fixes it.
References
Advisory data from OSV.dev (opens OSV.dev in a new tab), refreshed daily.