HighGHSA-8xwg-wv7v-4vqpCVE-2018-1000136
Electron Vulnerable to Code Execution by Re-Enabling Node.js Integration
Published 26 Mar 2018 · Updated 8 Nov 2023
Affected packages
electronnpm
- Affected
- >=1.7.0 <1.7.13
- Fixed in
- 1.7.13
Update to the fixed version for your release line, for example:
npm install electron@1.7.13electronnpm
- Affected
- >=1.8.0 <1.8.4
- Fixed in
- 1.8.4
Update to the fixed version for your release line, for example:
npm install electron@1.8.4electronnpm
- Affected
- >=2.0.0-beta.1 <2.0.0-beta.5
- Fixed in
- 2.0.0-beta.5
Update to the fixed version for your release line, for example:
npm install electron@2.0.0-beta.5Details
A vulnerability has been discovered which allows Node.js integration to be re-enabled in some Electron applications that disable it.
For the application to be impacted by this vulnerability it must meet all of these conditions
- Runs on Electron 1.7, 1.8, or a 2.0.0-beta
- Allows execution of arbitrary remote code
- Disables Node.js integration
- Does not explicitly declare webviewTag: false in its webPreferences
- Does not enable the nativeWindowOption option
- Does not intercept new-window events and manually override event.newGuest without using the supplied options tag
Recommendation
Update to electron version 1.7.13, 1.8.4, or 2.0.0-beta.5 or later.
If you are unable to update your Electron version can mitigate the vulnerability with the following code.
app.on('web-contents-created', (event, win) => {
win.on('new-window', (event, newURL, frameName, disposition,
options, additionalFeatures) => {
if (!options.webPreferences) options.webPreferences = {};
options.webPreferences.nodeIntegration = false;
options.webPreferences.nodeIntegrationInWorker = false;
options.webPreferences.webviewTag = false;
delete options.webPreferences.preload;
})
})
// and *IF* you don't use WebViews at all,
// you might also want
app.on('web-contents-created', (event, win) => {
win.on('will-attach-webview', (event, webPreferences, params) => {
event.preventDefault();
})
})Is GHSA-8xwg-wv7v-4vqp in any of your client repos?
Checking one package by hand is fine. Checking it across forty client projects is not. NPMscan reads the lockfiles in every GitHub repo you pick, finds each project with an affected electron, and gives you the command that fixes it.
References
- Advisorynvd.nist.gov/vuln/detail/CVE-2018-1000136
- Linkgithub.com/electron/electron/pull/12271
- Linkgithub.com/electron/electron/pull/12292
- Linkgithub.com/electron/electron/pull/12294
- Linkgithub.com/electron/electron/commit/1a48ee28276e6588dbf4e70e58d78e7bfdc57043
- Linkelectronjs.org/blog/webview-fix
- Packagegithub.com/electron/electron
- Linkwww.electronjs.org/blog/webview-fix
- Linkwww.npmjs.com/advisories/574
- Linkwww.trustwave.com/Resources/SpiderLabs-Blog/CVE-2018-1000136---Electron-nodeIntegration-Bypass
Advisory data from OSV.dev (opens OSV.dev in a new tab), refreshed daily.