SQL Injection in sequelize
Published 18 Feb 2019 · Updated 8 Nov 2023
Affected package
- Affected
- <3.20.0
- Fixed in
- 3.20.0
npm install sequelize@3.20.0Details
Affected versions of sequelize cast arrays to strings and fail to properly escape the resulting SQL statement, resulting in a SQL injection vulnerability.
Proof of Concept
In Postgres, SQLite, and Microsoft SQL Server there is an issue where arrays are treated as strings and improperly escaped.
Example Query:
database.query('SELECT * FROM TestTable WHERE Name IN (:names)', {
replacements: {
names: directCopyOfUserInput
}
});If the user inputs the value of :names as:
["test", "'); DELETE TestTable WHERE Id = 1 --')"]
The resulting SQL statement will be:
SELECT Id FROM Table WHERE Name IN ('test', '\'); DELETE TestTable WHERE Id = 1 --')As the backslash has no special meaning in PostgreSQL, MSSQL, or SQLite, the statement will delete the record in TestTable with an Id of 1.
Recommendation
Update to version 3.20.0 or later.
Is GHSA-9c2p-jw8p-f84v in any of your client repos?
Checking one package by hand is fine. Checking it across forty client projects is not. NPMscan reads the lockfiles in every GitHub repo you pick, finds each project with an affected sequelize, and gives you the command that fixes it.
References
- Advisorynvd.nist.gov/vuln/detail/CVE-2016-10556
- Linkgithub.com/sequelize/sequelize/issues/5671
- Linkgithub.com/sequelize/sequelize/commit/23952a2b020cc3571f090e67dae7feb084e1be71
- Linkgithub.com/sequelize/sequelize/commits/v3.20.0?after=62e4dacb28a779a190a3e042b971dcd8c7926e49+34&branch=v3.20.0&qualified_name=refs%2Ftags%2Fv3.20.0
Advisory data from OSV.dev (opens OSV.dev in a new tab), refreshed daily.