Remote shell execution vulnerability in image_processing
Published 1 Mar 2022 · Updated 8 Nov 2023
Is your project on an affected image_processing?
Look after several Rails or Ruby apps? Indie watches up to 15 repos, private ones too, for $5 a month. See Indie
Affected package
- Affected
- <1.12.2
- Fixed in
- 1.12.2
bundle update --conservative image_processing # Gemfile: '>= 1.12.2'Details
Impact
When using the #apply method from image_processing to apply a series of operations that are coming from unsanitized user input, this allows the attacker to execute shell commands:
ImageProcessing::Vips.apply({ system: "echo EXECUTED" })
#>> EXECUTEDThis method is called internally by Active Storage variants, so Active Storage is vulnerable as well.
Patches
The vulnerability has been fixed in version 1.12.2 of image_processing.
Workarounds
If you're processing based on user input, it's highly recommended that you always sanitize the user input, by allowing only a constrained set of operations. For example:
operations = params[:operations]
.map { |operation| [operation[:name], *operation[:value]] }
.select { |name, *| name.to_s.include? %w[resize_to_limit strip ...] } # sanitization
ImageProcessing::Vips.apply(operations)Is GHSA-cxf7-qrc5-9446 in any of your client repos?
Checking one package by hand is fine. Checking it across forty client projects is not. NPMscan reads the lockfiles in every GitHub repo you pick, finds each project with an affected image_processing, and gives you the command that fixes it.
References
- Linkgithub.com/janko/image_processing/security/advisories/GHSA-cxf7-qrc5-9446
- Advisorynvd.nist.gov/vuln/detail/CVE-2022-24720
- Linkgithub.com/janko/image_processing/commit/038e4574e8f4f4b636a62394e09983c71980dada
- Packagegithub.com/janko/image_processing
- Linkgithub.com/rubysec/ruby-advisory-db/blob/master/gems/image_processing/CVE-2022-24720.yml
- Linkwww.debian.org/security/2022/dsa-5310
Advisory data from OSV.dev (opens OSV.dev in a new tab), refreshed daily.