HighGHSA-j563-grx4-pjpvCVE-2022-41966

XStream can cause Denial of Service via stack overflow

Published 29 Dec 2022 · Updated 16 Feb 2024

Is your project on an affected com.thoughtworks.xstream:xstream?

Private repo? Upload its lockfile instead, or connect GitHub to check every repo.

Look after several Java apps? Indie watches up to 15 repos, private ones too, for $5 a month. See Indie

Affected package

Affected
<1.4.20
Fixed in
1.4.20
Update to the fixed version for your release line, for example:mvn versions:use-dep-version -Dincludes=com.thoughtworks.xstream:xstream -DdepVersion=1.4.20 -DforceVersion=true

Details

Impact

The vulnerability may allow a remote attacker to terminate the application with a stack overflow error resulting in a denial of service only by manipulating the processed input stream.

Patches

XStream 1.4.20 handles the stack overflow and raises an InputManipulationException instead.

Workarounds

The attack uses the hash code implementation for collections and maps to force recursive hash calculation causing a stack overflow. Following types of the Java runtime are affected:

  • java.util.HashMap
  • java.util.HashSet
  • java.util.Hashtable
  • java.util.LinkedHashMap
  • java.util.LinkedHashSet
  • Other third party collection implementations that use their element's hash code may also be affected

A simple solution is to catch the StackOverflowError in the client code calling XStream.

If your object graph does not use referenced elements at all, you may simply set the NO_REFERENCE mode:

XStream xstream = new XStream();
xstream.setMode(XStream.NO_REFERENCES);

If your object graph contains neither a Hashtable, HashMap nor a HashSet (or one of the linked variants of it) then you can use the security framework to deny the usage of these types:

XStream xstream = new XStream();
xstream.denyTypes(new Class[]{
 java.util.HashMap.class, java.util.HashSet.class, java.util.Hashtable.class, java.util.LinkedHashMap.class, java.util.LinkedHashSet.class
});

Unfortunately these types are very common. If you only use HashMap or HashSet and your XML refers these only as default map or set, you may additionally change the default implementation of java.util.Map and java.util.Set at unmarshalling time::

xstream.addDefaultImplementation(java.util.TreeMap.class, java.util.Map.class);
xstream.addDefaultImplementation(java.util.TreeSet.class, java.util.Set.class);

However, this implies that your application does not care about the implementation of the map and all elements are comparable.

References

See full information about the nature of the vulnerability and the steps to reproduce it in XStream's documentation for CVE-2022-41966.

For more information

If you have any questions or comments about this advisory:

Is GHSA-j563-grx4-pjpv in any of your client repos?

Checking one package by hand is fine. Checking it across forty client projects is not. NPMscan reads the lockfiles in every GitHub repo you pick, finds each project with an affected com.thoughtworks.xstream:xstream, and gives you the command that fixes it.

More advisories for com.thoughtworks.xstream:xstream

  • HighCVE-2024-47072XStream is vulnerable to a Denial of Service attack due to stack overflow from a manipulated binary input stream · 7 Nov 2024
  • HighCVE-2022-40151XStream can cause a Denial of Service by injecting deeply nested objects raising a stack overflow · 30 Dec 2022
  • HighCVE-2021-43859Denial of Service by injecting highly recursive collections or maps in XStream · 1 Feb 2022
  • HighCVE-2021-39139XStream is vulnerable to an Arbitrary Code Execution attack · 25 Aug 2021
  • MediumCVE-2021-39140XStream can cause a Denial of Service · 25 Aug 2021
  • HighCVE-2021-39141XStream is vulnerable to an Arbitrary Code Execution attack · 25 Aug 2021
All 37 advisories for com.thoughtworks.xstream:xstream

References

Advisory data from OSV.dev (opens OSV.dev in a new tab), refreshed daily.