MediumGHSA-qp29-wcc2-vmpc

Silverstripe HtmlEditor embed url sanitisation

Published 23 May 2024 · Updated 28 Nov 2024

Affected package

silverstripe/frameworkComposer
Affected
>=3.0.0 <3.2.1
Fixed in
3.2.1
Update to the fixed version for your release line, for example:composer require silverstripe/framework:^3.2.1

Details

"Add from URL" doesn't clearly sanitise URL server side

HtmlEditorField_Toolbar has an action HtmlEditorField_Toolbar#viewfile, which gets called by the CMS when adding a media "from a URL" (i.e. via oembed).

This action gets the URL to add in the GET parameter FileURL. However it doesn't do any URL sanitising server side. The current logic will pass this through to Oembed, which will probably reject most dangerous URLs, but it's possible future changes would break this.

Is GHSA-qp29-wcc2-vmpc in any of your client repos?

Checking one package by hand is fine. Checking it across forty client projects is not. NPMscan reads the lockfiles in every GitHub repo you pick, finds each project with an affected silverstripe/framework, and gives you the command that fixes it.

Scan a project free, no signupOr connect GitHub to scan every repo

References

Advisory data from OSV.dev (opens OSV.dev in a new tab), refreshed daily.