MediumGHSA-vfm6-r2gc-pwww

Symfony2 security issue when the trust proxy mode is enabled

Published 30 May 2024 · Updated 4 Dec 2024

Affected packages

Affected
>=2.0.0 <2.0.19
Fixed in
2.0.19
Update to the fixed version for your release line, for example:composer require symfony/http-foundation:^2.0.19
Affected
>=2.1.0 <2.1.4
Fixed in
2.1.4
Update to the fixed version for your release line, for example:composer require symfony/http-foundation:^2.1.4
Affected
>=2.0.0 <2.0.19
Fixed in
2.0.19
Update to the fixed version for your release line, for example:composer require symfony/symfony:^2.0.19
Affected
>=2.1.0 <2.1.4
Fixed in
2.1.4
Update to the fixed version for your release line, for example:composer require symfony/symfony:^2.1.4

Details

An application is vulnerable if it uses the client IP address as returned by the Request::getClientIp() method for sensitive decisions like IP based access control.

To fix this security issue, the following changes have been made to all versions of Symfony2:

A new Request::setTrustedProxies() method has been introduced and should be used intead of Request::trustProxyData() to enable the trust proxy mode. It takes an array of trusted proxy IP addresses as its argument:

// before (probably in your front controller script)
Request::trustProxyData();

// after
Request::setTrustedProxies(array('1.1.1.1'));
// 1.1.1.1 being the IP address of a trusted reverse proxy

The Request::trustProxyData() method has been deprecated (when used, it automatically trusts the latest proxy in the chain -- which is the current remote address):

Request::trustProxyData();

// is equivalent to
Request::setTrustedProxies(array($request->server->get('REMOTE_ADDR')));

We encourage all Symfony2 users to upgrade as soon as possible. It you don't want to upgrade to the latest version yet, you can also apply the following patches:

Is GHSA-vfm6-r2gc-pwww in any of your client repos?

Checking one package by hand is fine. Checking it across forty client projects is not. NPMscan reads the lockfiles in every GitHub repo you pick, finds each project with an affected symfony/http-foundation, and gives you the command that fixes it.

References

Advisory data from OSV.dev (opens OSV.dev in a new tab), refreshed daily.