Silverstripe Missing security check on dev/build/defaults
Published 23 May 2024 · Updated 28 Nov 2024
Affected packages
- Affected
- <3.1.17
- Fixed in
- 3.1.17
composer require silverstripe/framework:^3.1.17- Affected
- >=3.2.0 <3.2.2
- Fixed in
- 3.2.2
composer require silverstripe/framework:^3.2.2- Affected
- >=3.3.0-beta1 <3.3.0
- Fixed in
- 3.3.0
composer require silverstripe/framework:^3.3.0Details
The buildDefaults method on DevelopmentAdmin is missing a permission check.
In live mode, if you access /dev/build, you are requested to login first. However, if you access /dev/build/defaults, then the action is performed without any login check. This should be protected in the same way that /dev/build is. The buildDefaults view is requireDefaultRecords() on each DataObject class, and hence has the potential to modify database state. It also lists all modified tables, allowing attackers more insight into which modules are used, and how the database tables are structured.
Is GHSA-x5w2-wcr8-9q45 in any of your client repos?
Checking one package by hand is fine. Checking it across forty client projects is not. NPMscan reads the lockfiles in every GitHub repo you pick, finds each project with an affected silverstripe/framework, and gives you the command that fixes it.
References
- Linkgithub.com/silverstripe/silverstripe-framework/commit/15d4db3b4a7dbc9a7e089f9329a396f8408ed7d9
- Linkgithub.com/silverstripe/silverstripe-framework/commit/3398f670d881447f8777b567f1ead7c0d8d253f5
- Linkgithub.com/silverstripe/silverstripe-framework/commit/5d2fc0d7cac4ce686f7ae05c1a7b1ad8c01711a8
- Linkgithub.com/FriendsOfPHP/security-advisories/blob/master/silverstripe/framework/SS-2015-028-1.yaml
- Packagegithub.com/silverstripe/silverstripe-framework
- Linkwww.silverstripe.org/download/security-releases/ss-2015-028
Advisory data from OSV.dev (opens OSV.dev in a new tab), refreshed daily.