HighGHSA-4f7p-27jc-3c36CVE-2022-24761PYSEC-2022-169

HTTP Request Smuggling in waitress

Published 18 Mar 2022 · Updated 19 Nov 2024

Is your project on an affected waitress?

Private repo? Upload its lockfile instead, or connect GitHub to check every repo.

Look after several Python apps? Indie watches up to 15 repos, private ones too, for $5 a month. See Indie

Affected package

Affected
<2.1.1
Fixed in
2.1.1
Update to the fixed version for your release line, for example:pip install 'waitress>=2.1.1'

Details

Impact

When using Waitress behind a proxy that does not properly validate the incoming HTTP request matches the RFC7230 standard, Waitress and the frontend proxy may disagree on where one request starts and where it ends.

This would allow requests to be smuggled via the front-end proxy to waitress and later behavior.

There are two classes of vulnerability that may lead to request smuggling that are addressed by this advisory:

  • The use of Python's int() to parse strings into integers, leading to +10 to be parsed as 10, or 0x01 to be parsed as 1, where as the standard specifies that the string should contain only digits or hex digits.
  • Waitress does not support chunk extensions, however it was discarding them without validating that they did not contain illegal characters

Patches

This has been fixed in Waitress 2.1.1

Workarounds

When deploying a proxy in front of waitress, turning on any and all functionality to make sure that the request matches the RFC7230 standard. Certain proxy servers may not have this functionality though and users are encouraged to upgrade to the latest version of waitress instead.

References

  • https://portswigger.net/research/http-desync-attacks-request-smuggling-reborn

For more information

If you have any questions or comments about this advisory:

  • Open an issue in the Github issue tracker (if not security related/sensitive)
  • Email us at [pylons-project-security@googlegroups.com](mailto:pylons-project-security@googlegroups.com) (If security related or sensitive)

Is GHSA-4f7p-27jc-3c36 in any of your client repos?

Checking one package by hand is fine. Checking it across forty client projects is not. NPMscan reads the lockfiles in every GitHub repo you pick, finds each project with an affected waitress, and gives you the command that fixes it.

More advisories for waitress

  • CriticalCVE-2024-49768Waitress has request processing race condition in HTTP pipelining with invalid first request · 29 Oct 2024
  • HighCVE-2024-49769Waitress vulnerable to DoS leading to high CPU usage/resource exhaustion · 29 Oct 2024
  • HighCVE-2022-31015Uncaught Exception (due to a data race) leads to process termination in Waitress · 2 Jun 2022
  • MediumCVE-2020-5236Catastrophic backtracking in regex allows Denial of Service in Waitress · 4 Feb 2020
  • MediumCVE-2019-16789HTTP Request Smuggling in Waitress: Invalid whitespace characters in headers (Follow-up) · 6 Jan 2020
  • HighGHSA-m5ff-3wj3-8ph4HTTP Request Smuggling: Invalid whitespace characters in headers in Waitress · 26 Dec 2019
All 10 advisories for waitress

References

Advisory data from OSV.dev (opens OSV.dev in a new tab), refreshed daily.