HTTP Request Smuggling: Invalid whitespace characters in headers in Waitress
Published 26 Dec 2019 · Updated 17 Feb 2025
Is your project on an affected waitress?
Look after several Python apps? Indie watches up to 15 repos, private ones too, for $5 a month. See Indie
Affected package
- Affected
- <1.4.1
- Fixed in
- 1.4.1
pip install 'waitress>=1.4.1'Details
Impact
If a proxy server is used in front of waitress, an invalid request may be sent by an attacker that bypasses the front-end and is parsed differently by waitress leading to a potential for HTTP request smuggling.
Content-Length: 10 Transfer-Encoding: [\x0b]chunked
For clarity:
0x0b == vertical tab
Would get parsed by Waitress as being a chunked request, but a front-end server would use the Content-Length instead as the Transfer-Encoding header is considered invalid due to containing invalid characters.
If a front-end server does HTTP pipelining to a backend Waitress server this could lead to HTTP request splitting which may lead to potential cache poisoning or unexpected information disclosure.
Patches
Please upgrade to Waitress 1.4.1 which fixes this issue with stricter HTTP field validation.
Waitress 1.4.1 due to this change has become much more strict in what is allowed in header values, while the maintainers don't believe that these changes will cause any issues, it may cause failures with non-conformist reverse proxies or clients, and it is highly recommend that users validate the changes in their environment and make sure it won't cause any unacceptable failures.
Workarounds
You may enable additional protections on front-end servers, those that follow RFC7230 correctly would drop the request with a 400 Bad Request.
Waitress will now correctly responds to the request with a 400 Bad Request, and will drop the connection to avoid any potential HTTP pipelining issues.
References
This was mentioned in https://portswigger.net/research/http-desync-attacks-what-happened-next and was specifically mentioned as being an issue in HAProxy which did not properly filter it in this article: https://nathandavison.com/blog/haproxy-http-request-smuggling
Thanks
The Pylons Project would like to thank ZeddYu Lu for doing extended testing against Waitress 1.4.0 and bringing this to our attention!
For more information
If you have any questions or comments about this advisory:
- open an issue at https://github.com/Pylons/waitress/issues (if not sensitive or security related)
- email the Pylons Security mailing list: pylons-project-security@googlegroups.com (if security related)
Is GHSA-m5ff-3wj3-8ph4 in any of your client repos?
Checking one package by hand is fine. Checking it across forty client projects is not. NPMscan reads the lockfiles in every GitHub repo you pick, finds each project with an affected waitress, and gives you the command that fixes it.
More advisories for waitress
- CriticalCVE-2024-49768Waitress has request processing race condition in HTTP pipelining with invalid first request · 29 Oct 2024
- HighCVE-2024-49769Waitress vulnerable to DoS leading to high CPU usage/resource exhaustion · 29 Oct 2024
- HighCVE-2022-31015Uncaught Exception (due to a data race) leads to process termination in Waitress · 2 Jun 2022
- HighCVE-2022-24761HTTP Request Smuggling in waitress · 18 Mar 2022
- MediumCVE-2020-5236Catastrophic backtracking in regex allows Denial of Service in Waitress · 4 Feb 2020
- MediumCVE-2019-16789HTTP Request Smuggling in Waitress: Invalid whitespace characters in headers (Follow-up) · 6 Jan 2020
References
Advisory data from OSV.dev (opens OSV.dev in a new tab), refreshed daily.