MediumGHSA-pg36-wpm5-g57pCVE-2019-16785PYSEC-2019-136

HTTP Request Smuggling: LF vs CRLF handling in Waitress

Published 20 Dec 2019 · Updated 10 Sept 2026

Is your project on an affected waitress?

Private repo? Upload its lockfile instead, or connect GitHub to check every repo.

Look after several Python apps? Indie watches up to 15 repos, private ones too, for $5 a month. See Indie

Affected package

Affected
<1.4.0
Fixed in
1.4.0
Update to the fixed version for your release line, for example:pip install 'waitress>=1.4.0'

Details

Impact

Waitress implemented a &amp;quot;MAY&amp;quot; part of the RFC7230 (https://tools.ietf.org/html/rfc7230#section-3.5) which states:

Although the line terminator for the start-line and header fields is the sequence CRLF, a recipient MAY recognize a single LF as a line terminator and ignore any preceding CR.

Unfortunately if a front-end server does not parse header fields with an LF the same way as it does those with a CRLF it can lead to the front-end and the back-end server parsing the same HTTP message in two different ways. This can lead to a potential for HTTP request smuggling/splitting whereby Waitress may see two requests while the front-end server only sees a single HTTP message.

Example:

Content-Length: 100[CRLF]
X-Header: x[LF]Content-Length: 0[CRLF]

Would get treated by Waitress as if it were:

Content-Length: 100
X-Header: x
Content-Length: 0

This could potentially get used by attackers to split the HTTP request and smuggle a second request in the body of the first.

Patches

This issue is fixed in Waitress 1.4.0. This brings a range of changes to harden Waitress against potential HTTP request confusions, and may change the behaviour of Waitress behind non-conformist proxies.

Waitress no longer implements the MAY part of the specification and instead requires that all lines are terminated correctly with CRLF. If any lines are found with a bare CR or LF a 400 Bad Request is sent back to the requesting entity.

The Pylons Project recommends upgrading as soon as possible, while validating that the changes in Waitress don&amp;#39;t cause any changes in behavior.

Workarounds

Various reverse proxies may have protections against sending potentially bad HTTP requests to the backend, and or hardening against potential issues like this. If the reverse proxy doesn&amp;#39;t use HTTP/1.1 for connecting to the backend issues are also somewhat mitigated, as HTTP pipelining does not exist in HTTP/1.0 and Waitress will close the connection after every single request (unless the Keep Alive header is explicitly sent... so this is not a fool proof security method)

Issues/more security issues:

  • open an issue at https://github.com/Pylons/waitress/issues (if not sensitive or security related)
  • email the Pylons Security mailing list: pylons-project-security@googlegroups.com (if security related)

Is GHSA-pg36-wpm5-g57p in any of your client repos?

Checking one package by hand is fine. Checking it across forty client projects is not. NPMscan reads the lockfiles in every GitHub repo you pick, finds each project with an affected waitress, and gives you the command that fixes it.

More advisories for waitress

  • CriticalCVE-2024-49768Waitress has request processing race condition in HTTP pipelining with invalid first request · 29 Oct 2024
  • HighCVE-2024-49769Waitress vulnerable to DoS leading to high CPU usage/resource exhaustion · 29 Oct 2024
  • HighCVE-2022-31015Uncaught Exception (due to a data race) leads to process termination in Waitress · 2 Jun 2022
  • HighCVE-2022-24761HTTP Request Smuggling in waitress · 18 Mar 2022
  • MediumCVE-2020-5236Catastrophic backtracking in regex allows Denial of Service in Waitress · 4 Feb 2020
  • MediumCVE-2019-16789HTTP Request Smuggling in Waitress: Invalid whitespace characters in headers (Follow-up) · 6 Jan 2020
All 10 advisories for waitress

References

Advisory data from OSV.dev (opens OSV.dev in a new tab), refreshed daily.